Delete GPSLatitudeRef, GPSLongitudeRef from INSERT INTO query and from CREATE TABLE query.
https://git.iamonlyherefortheicecream.ml/DIWHY/photovoter_backend/src/commit/6bd14777a38b88a24fe040373aebaee556337656/util/import_photos.py#L120-L138
Delete `GPSLatitudeRef`, `GPSLongitudeRef` from `INSERT INTO` query and from `CREATE TABLE` query.
Not sure if I did a right thing opening a new issue for this fix request. Where should I put requests like this? PR conversation? Review?
Generally, i'd say:
syntactic error/unsound logic in the PR — code review comment particular lines (should probably be colored lines)
more to be done in the PR — general review comment
problem/question with the current code — issue
don't know which one it should be — slap a new issue anyway
So this will work.
> Not sure if I did a right thing opening a new issue for this fix request. Where should I put requests like this? PR conversation? Review?
Generally, i'd say:
* syntactic error/unsound logic in the PR — code review comment particular lines (should probably be colored lines)
* more to be done in the PR — general review comment
* problem/question with the current code — issue
* don't know which one it should be — slap a new issue anyway
So this will work.
Not sure if I did a right thing opening a new issue for this fix request. Where should I put requests like this? PR conversation? Review?
Generally, i'd say:
syntactic error/unsound logic in the PR — code review comment particular lines (should probably be colored lines)
more to be done in the PR — general review comment
problem/question with the current code — issue
don't know which one it should be — slap a new issue anyway
So this will work.
Well noted. Thank you!
> > Not sure if I did a right thing opening a new issue for this fix request. Where should I put requests like this? PR conversation? Review?
>
> Generally, i'd say:
> * syntactic error/unsound logic in the PR — code review comment particular lines (should probably be colored lines)
> * more to be done in the PR — general review comment
> * problem/question with the current code — issue
> * don't know which one it should be — slap a new issue anyway
>
> So this will work.
Well noted. Thank you!
6bd14777a3/util/import_photos.py (L120-L138)Delete
GPSLatitudeRef,GPSLongitudeReffromINSERT INTOquery and fromCREATE TABLEquery.Not sure if I did a right thing opening a new issue for this fix request. Where should I put requests like this? PR conversation? Review?
Generally, i'd say:
So this will work.
Well noted. Thank you!